CM-1099 LiveArt External Adapter #4018
Conversation
…d for preparing requests and parsing response
🦋 Changeset detectedLatest commit: e4bb691 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| API_BASE_URL: { | ||
| description: 'The API URL for the LiveArt data provider', | ||
| type: 'string', | ||
| required: true, | ||
| }, |
There was a problem hiding this comment.
Can we put a default url here?
There was a problem hiding this comment.
what is a defaultURL? is that just a base url?
There was a problem hiding this comment.
Yes, you can put a default value here so NOPs won't have to configure it individually
| export type Config = { | ||
| API_BASE_URL: string | ||
| BEARER_TOKEN: string | ||
| } |
There was a problem hiding this comment.
Where else would i be able to define secrets to be pulled into the ea?
There was a problem hiding this comment.
We've never had the need to define a structure like it. You should be able to access it via the existing config structure
| @@ -0,0 +1,9 @@ | |||
| { | |||
There was a problem hiding this comment.
Need a tsconfig.test.json
as well as these two file under root
There was a problem hiding this comment.
packages/tsconfig.json and another one for test
There was a problem hiding this comment.
packages/tsconfig.json and another one for test
| @@ -0,0 +1,88 @@ | |||
| import nock from 'nock' | |||
There was a problem hiding this comment.
Move this to integration test folder
| const data = { artwork_id: 'banksy' } | ||
| const params = [data] | ||
| const mockResponseData: ResponseSchema = { | ||
| ...SuccessResponse, |
There was a problem hiding this comment.
Do you need to mock the entire thing here?
There was a problem hiding this comment.
I dont have to but its good practice as we would 100% recreate production request/response.
| } | ||
| } | ||
|
|
||
| export function createMockResponse( |
There was a problem hiding this comment.
I don't feel this is neceessary
There was a problem hiding this comment.
I use this to test my parseResponse function and to not have type warnings. How differently would you do it?
There was a problem hiding this comment.
Just use
{
data,
status,
statusText,
headers: {},
config: {} as any,
}
You can do as any as your are already doing to remove warnings
Closes OPDATA-4029 / CM-1099
Description
LiveArt External Adapter (EA) to fetch art nav_per_share numerical data.
......
Changes
Steps to Test
From root directory
Quality Assurance
infra-k8sconfiguration file.adapter-secretsconfiguration file or update the soak testing blacklist.test-payload.jsonfile with relevant requests.feature/x,chore/x,release/x,hotfix/x,fix/x) or is created from Jira.